runtime: name all four components builder params in CoreRuntime - #532
Merged
Conversation
mfw78
force-pushed
the
fix/508-core-runtime-components-params
branch
from
July 23, 2026 14:15
b56694b to
9db82b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Name all four builder type params explicitly in
CoreRuntime::components(crates/nexum-runtime/src/preset.rs), widening the return type fromComponentsBuilder<ProviderPoolBuilder, LocalStoreBuilder, ()>toComponentsBuilder<ProviderPoolBuilder, LocalStoreBuilder, (), LogPipelineBuilder>.Why
The prior signature leaned on the
L = LogPipelineBuilderdefault for the logs builder param. Spelling out theLogsBuilderparam makes the return type match theRuntimetrait's declared associated type exactly rather than relying on a defaulted param. No behaviour change: the body is unchanged and still constructsComponentsBuilder::new(ProviderPoolBuilder, LocalStoreBuilder, ()).LogPipelineBuilderwas already imported.Testing
cargo fmt --all -- --checkis clean (rustfmt spreads the signature across three lines).cargo clippy -p nexum-runtime --all-targets --all-featuresaftercargo clean -p nexum-runtime.AI Assistance
Implemented, reviewed and verified with Claude Code (Opus).
Closes #508